JOSS paper preparation - #1249
danielfromearth wants to merge 45 commits into
Conversation
|
I will automatically update this comment whenever this PR is modified
|
jules32
left a comment
There was a problem hiding this comment.
Hi! Great work on this Danny! A few commits and some suggestions to consider.
Co-authored-by: Julia Stewart Lowndes <julia@openscapes.org>
I would say let's not wait. We've demonstrated impact and I think that matters more. Alternatively, let's just go 1.0.0 in the short term and be OK with quickly moving to a 2.0.0 release with breaking changes. I think both are fine, but the latter sets more a precedent of maintainers taking the user impact of breaking changes too lightly. |
Co-authored-by: Matt Fisher <3608264+mfisher87@users.noreply.github.com>
I'm fine with either too. I also think the decision could be on hold until one of the two things – (i) co-author reviews/revisions, (ii) development for v1.0.0 – is completely ready-to-go. |
- remove "ongoing" since (a) it's mostly done and (b) won't be ongoing for future readers. - remove residual redundancy from Earthdata Cloud rewording - backtick VirtualiZarr, kerchunk, and xarray package names throughout Co-authored-by: Ian Carroll <ian.t.carroll@nasa.gov>
Sign-off tracking has moved to the PR description.I've added an author sign-off table there. I'll track approvals against What I need from each of you:
Item 1 takes about fifteen seconds. Reply here, approve the PR, or message me in Slack – and I'll keep the table updated either way. By 23 September: if I haven't heard from you, I'll take that as no further edits requested. Though, if you'd like more time, let me know! |
Co-authored-by: Chuck Daniels <chuck@developmentseed.org>
chuckwondo
left a comment
There was a problem hiding this comment.
Thanks for tweaking the DevSeed entry @danielfromearth!
asteiker
left a comment
There was a problem hiding this comment.
Confirmed my author info and gave it another quick read. Looks great, thank you so much @danielfromearth for leading this!
There was a problem hiding this comment.
Great work team! thanks for leading this effort @danielfromearth!
Sherwin-14
left a comment
There was a problem hiding this comment.
Thanks @danielfromearth ! Approved from my side.
JessicaS11
left a comment
There was a problem hiding this comment.
Looks great - thanks, Danny!
Updated the ror for my affiliations and left a few suggested edits about commas and passive voice. Pending the ror correction, I approve both 1 and 2.
Co-authored-by: Jessica Scheick <JessicaS11@users.noreply.github.com>
69155cd
Co-authored-by: Daniel Kaufman <114174502+danielfromearth@users.noreply.github.com> Co-authored-by: Jessica Scheick <JessicaS11@users.noreply.github.com>
Manuscript draft
This PR is intended for revisions and improvements to the manuscript draft being prepared for submission to the Journal of Open Source Software (JOSS).
Paper format: The manuscript is prepared as a Markdown (
paper.md) file with references in apaper.bibfile, following the JOSS formatting guidelines.For a PDF preview: With docker installed locally, a PDF preview of the draft manuscript can be generated, by running the following from the earthaccess root directory (as described in the JOSS guidelines's docker section):
Author sign-off
Approvals below apply to the manuscript as of
06dce59and carry forward through later commits that don't change meaning, such as typos, line wrapping,.bibformatting. If a revision meaningfully changes the substance of the manuscript, I'll clear the affected rows and ping those authors directly.To sign off: confirm your author entry (name, affiliation, ORCID) is correct and that you approve the current draft — reply here, approve the PR, or message me in Slack.
Related pyOpenSci review issue: pyOpenSci/software-submission#302
📚 Documentation preview 📚: https://earthaccess--1249.org.readthedocs.build/en/1249/